Skip to content

Conversation

rhshadrach
Copy link
Member

  • Ensure all linting tests pass, see here for how to run them

@rhshadrach rhshadrach added this to the 1.3 milestone Jun 23, 2021
@jreback
Copy link
Contributor

jreback commented Jun 23, 2021

hmm mypy is failing oddly

@rhshadrach
Copy link
Member Author

Comparing to the most recent commit on master, I'm seeing numpy 1.21.0 here and 1.20.3 there.

@rhshadrach rhshadrach mentioned this pull request Jun 23, 2021
@rhshadrach
Copy link
Member Author

CI failure is unrelated (ref #42196), @jreback and @simonjayhawkins for review.

@jreback jreback merged commit 20a6662 into pandas-dev:master Jun 24, 2021
@jreback
Copy link
Contributor

jreback commented Jun 24, 2021

thanks @rhshadrach

@jreback
Copy link
Contributor

jreback commented Jun 24, 2021

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jun 24, 2021

Something went wrong ... Please have a look at my logs.

@rhshadrach rhshadrach deleted the whatsnew_other branch June 24, 2021 13:08
@rhshadrach rhshadrach restored the whatsnew_other branch June 24, 2021 13:08
jreback pushed a commit that referenced this pull request Jun 24, 2021
@rhshadrach rhshadrach deleted the whatsnew_other branch June 25, 2021 02:50
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants